Fix passing large arrays with JS values into Wasm detaching memory #4353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
changed the title
daxpedda
changed the title
daxpedda
force-pushed
the
js-to-wasm-detached
branch
2 times, most recently
from
382ce52 to
5a68cbd
Compare
daxpedda
force-pushed
the
js-to-wasm-detached
branch
from
5a68cbd to
f4660ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing arrays with JS values from JS to Wasm we have to insert each entry into the reference type table. Each insertion can cause allocation, which invalidates the memory buffer and throws.
This PR fixes it by getting a new memory view after every insertion. This will likely degrade performance especially when passing large arrays. To fix this we have to find a way to pass a larger set of reference values without having to call into Rust each time.
Fixes #4352.